]> Cypherpunks repositories - gostls13.git/commitdiff
cmd/go: remove a redundant HasExec check in TestScript/README
authorBryan C. Mills <bcmills@google.com>
Tue, 2 May 2023 16:43:04 +0000 (12:43 -0400)
committerBryan Mills <bcmills@google.com>
Thu, 4 May 2023 16:22:43 +0000 (16:22 +0000)
The test checks testenv.HasExec right before calling testenv.Command,
but testenv.Command already skips the test if HasExec is false.

Change-Id: I04716bf823a1b76640394a964973ff34c65afb1f
Reviewed-on: https://go-review.googlesource.com/c/go/+/491658
Run-TryBot: Bryan Mills <bcmills@google.com>
Auto-Submit: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Michael Matloob <matloob@golang.org>
src/cmd/go/scriptreadme_test.go

index fde1e8e9f8fea49971e4979916f3e5b604d371c7..2a842fbc0f7b636d92ce644586b1e3e5c7084dd3 100644 (file)
@@ -37,10 +37,6 @@ func checkScriptReadme(t *testing.T, engine *script.Engine, env []string) {
        }
        args.Conditions = conds.String()
 
-       if !testenv.HasExec() {
-               t.Skipf("updating script README requires os/exec")
-       }
-
        doc := new(strings.Builder)
        cmd := testenv.Command(t, testGo, "doc", "cmd/go/internal/script")
        cmd.Env = env