]> Cypherpunks repositories - gostls13.git/commitdiff
runtime: fix and simplify printing on bad ftab
authorJosh Bleecher Snyder <josharian@gmail.com>
Fri, 24 Sep 2021 17:57:27 +0000 (10:57 -0700)
committerJosh Bleecher Snyder <josharian@gmail.com>
Mon, 27 Sep 2021 22:22:35 +0000 (22:22 +0000)
Unilaterally print plugin.
Use println instead of print.

Change-Id: Ib58f187bff9c3dbedfa2725c44754a222807cc36
Reviewed-on: https://go-review.googlesource.com/c/go/+/352072
Trust: Josh Bleecher Snyder <josharian@gmail.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
src/runtime/symtab.go

index 792513f79679d0ecd8e1a5b9142ad8c96f5402b5..0d0fe8055b30f303b2bbc2964446c28f3ebae714 100644 (file)
@@ -604,13 +604,9 @@ func moduledataverify1(datap *moduledata) {
                        if i+1 < nftab {
                                f2name = funcname(f2)
                        }
-                       print("function symbol table not sorted by program counter:", hex(datap.ftab[i].entry), funcname(f1), ">", hex(datap.ftab[i+1].entry), f2name)
-                       if datap.pluginpath != "" {
-                               print(", plugin:", datap.pluginpath)
-                       }
-                       println()
+                       println("function symbol table not sorted by PC:", hex(datap.ftab[i].entry), funcname(f1), ">", hex(datap.ftab[i+1].entry), f2name, ", plugin:", datap.pluginpath)
                        for j := 0; j <= i; j++ {
-                               print("\t", hex(datap.ftab[j].entry), " ", funcname(funcInfo{(*_func)(unsafe.Pointer(&datap.pclntable[datap.ftab[j].funcoff])), datap}), "\n")
+                               println("\t", hex(datap.ftab[j].entry), funcname(funcInfo{(*_func)(unsafe.Pointer(&datap.pclntable[datap.ftab[j].funcoff])), datap}))
                        }
                        if GOOS == "aix" && isarchive {
                                println("-Wl,-bnoobjreorder is mandatory on aix/ppc64 with c-archive")