]> Cypherpunks repositories - gostls13.git/commitdiff
net/http: test that we preserve Go 1.0 Request.Write Host behavior
authorBrad Fitzpatrick <bradfitz@golang.org>
Thu, 14 Feb 2013 02:33:15 +0000 (18:33 -0800)
committerBrad Fitzpatrick <bradfitz@golang.org>
Thu, 14 Feb 2013 02:33:15 +0000 (18:33 -0800)
Fixes #4792

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/7314093

src/pkg/net/http/requestwrite_test.go

index fc3186f0c0cb49af50201385a17daefa3dd458a7..3a5cd8ae2de1c84f8ce91b109baabd2ada927589 100644 (file)
@@ -328,6 +328,31 @@ var reqWriteTests = []reqWriteTest{
                        "User-Agent: Go http package\r\n" +
                        "X-Foo: X-Bar\r\n\r\n",
        },
+
+       // If no Request.Host and no Request.URL.Host, we send
+       // an empty Host header, and don't use
+       // Request.Header["Host"]. This is just testing that
+       // we don't change Go 1.0 behavior.
+       {
+               Req: Request{
+                       Method: "GET",
+                       Host:   "",
+                       URL: &url.URL{
+                               Scheme: "http",
+                               Host:   "",
+                               Path:   "/search",
+                       },
+                       ProtoMajor: 1,
+                       ProtoMinor: 1,
+                       Header: Header{
+                               "Host": []string{"bad.example.com"},
+                       },
+               },
+
+               WantWrite: "GET /search HTTP/1.1\r\n" +
+                       "Host: \r\n" +
+                       "User-Agent: Go http package\r\n\r\n",
+       },
 }
 
 func TestRequestWrite(t *testing.T) {