]> Cypherpunks repositories - gostls13.git/commitdiff
runtime: skip windows stack tests in race mode
authorMichael Pratt <mpratt@google.com>
Wed, 21 May 2025 17:36:42 +0000 (13:36 -0400)
committerGopher Robot <gobot@golang.org>
Wed, 21 May 2025 18:05:35 +0000 (11:05 -0700)
These became race instrumented in CL 643897, but race mode uses more
memory, so the test doesn't make much sense.

For #71395.

Change-Id: I6a6a636cf09ba29625aa9a22550314845fb2e611
Reviewed-on: https://go-review.googlesource.com/c/go/+/675077
Auto-Submit: Michael Pratt <mpratt@google.com>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>

src/runtime/crash_cgo_test.go
src/runtime/syscall_windows_test.go

index 34e33169d518c0962c20feca5048e17aaee1a965..c5d73032611b518406685730be49d2b71e92fd06 100644 (file)
@@ -597,6 +597,9 @@ func TestWindowsStackMemoryCgo(t *testing.T) {
        if runtime.GOOS != "windows" {
                t.Skip("skipping windows specific test")
        }
+       if race.Enabled {
+               t.Skip("skipping test: race mode uses more stack memory")
+       }
        testenv.SkipFlaky(t, 22575)
        o := runTestProg(t, "testprogcgo", "StackMemory")
        stackUsage, err := strconv.Atoi(o)
index 670926740356c252db4a11393c884683449e66de..ad9bfb464b24f0f70e538df44c6d7c0143f9f84a 100644 (file)
@@ -7,6 +7,7 @@ package runtime_test
 import (
        "fmt"
        "internal/abi"
+       "internal/race"
        "internal/syscall/windows/sysdll"
        "internal/testenv"
        "io"
@@ -668,6 +669,9 @@ func TestWERDialogue(t *testing.T) {
 }
 
 func TestWindowsStackMemory(t *testing.T) {
+       if race.Enabled {
+               t.Skip("skipping test: race mode uses more stack memory")
+       }
        o := runTestProg(t, "testprog", "StackMemory")
        stackUsage, err := strconv.Atoi(o)
        if err != nil {