net/http/httputil: use strings.Builder

Change-Id: Ifb51413894791154489bd1d4f529088958212c62
Reviewed-on: https://go-review.googlesource.com/c/go/+/428270
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Ian Lance Taylor <iant@google.com>
Auto-Submit: Ian Lance Taylor <iant@google.com>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>

diff --git a/src/net/http/httputil/dump_test.go b/src/net/http/httputil/dump_test.go
index 764750e2f7b42042ccb5482e5a5f8cb0b481a498..c20c054865fa32b12123d860489a63e20496db1d 100644 (file)
--- a/src/net/http/httputil/dump_test.go
+++ b/src/net/http/httputil/dump_test.go
@@ -523,7 +523,7 @@ func TestDumpRequestOutIssue38352(t *testing.T) {
                select {
                case <-out:
                case <-time.After(timeout):
-                       b := &bytes.Buffer{}
+                       b := &strings.Builder{}
                        fmt.Fprintf(b, "deadlock detected on iteration %d after %s with delay: %v\n", i, timeout, delay)
                        pprof.Lookup("goroutine").WriteTo(b, 1)
                        t.Fatal(b.String())

diff --git a/src/net/http/httputil/reverseproxy_test.go b/src/net/http/httputil/reverseproxy_test.go
index f8157e943526784e5ad9cb39419130dc95e8c9a5..549bc67b879c4625165919557e33d0b9022f320b 100644 (file)
--- a/src/net/http/httputil/reverseproxy_test.go
+++ b/src/net/http/httputil/reverseproxy_test.go
@@ -1123,7 +1123,7 @@ func TestModifyResponseClosesBody(t *testing.T) {
        req, _ := http.NewRequest("GET", "http://foo.tld/", nil)
        req.RemoteAddr = "1.2.3.4:56789"
        closeCheck := new(checkCloser)
-       logBuf := new(bytes.Buffer)
+       logBuf := new(strings.Builder)
        outErr := errors.New("ModifyResponse error")
        rp := &ReverseProxy{
                Director: func(req *http.Request) {},