]> Cypherpunks repositories - gostls13.git/commitdiff
cmd/doc: the builtin package should always show unexported symbols
authorRob Pike <r@golang.org>
Wed, 9 Sep 2015 18:01:01 +0000 (11:01 -0700)
committerRob Pike <r@golang.org>
Wed, 9 Sep 2015 19:46:08 +0000 (19:46 +0000)
Trivial fix: set unexported=true for builtin.
Godoc itself has a similar hack.

Fixes #12541

Change-Id: Ib701f867d117931eb6ec6de223941b52eb6cd4a7
Reviewed-on: https://go-review.googlesource.com/14441
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
src/cmd/doc/main.go

index 0985d95b60ac23a907c12a4f529ddde76cffb744..1f503e92facbfa00373094932a98b9731d80f35b 100644 (file)
@@ -87,6 +87,7 @@ func do(writer io.Writer, flagSet *flag.FlagSet, args []string) (err error) {
        buildPackage, userPath, symbol := parseArgs(flagSet.Args())
        symbol, method := parseSymbol(symbol)
        pkg := parsePackage(writer, buildPackage, userPath)
+
        defer func() {
                pkg.flush()
                e := recover()
@@ -100,6 +101,13 @@ func do(writer io.Writer, flagSet *flag.FlagSet, args []string) (err error) {
                }
                panic(e)
        }()
+
+       // The builtin package needs special treatment: its symbols are lower
+       // case but we want to see them, always.
+       if pkg.build.ImportPath == "builtin" {
+               unexported = true
+       }
+
        switch {
        case symbol == "":
                pkg.packageDoc()