]> Cypherpunks repositories - gostls13.git/commitdiff
cmd/compile: tweak ssa.html colors
authorJosh Bleecher Snyder <josharian@gmail.com>
Sat, 13 May 2017 15:29:47 +0000 (08:29 -0700)
committerJosh Bleecher Snyder <josharian@gmail.com>
Sun, 14 May 2017 12:54:30 +0000 (12:54 +0000)
Make yellow the last highlight color rather than the first.
Yellow is also the color that Chrome uses to highlight
search results, which can be confusing.
Also, when Night Shift is on on macOS,
yellow highlighting is completely invisible.
I suppose should be sleeping instead.

Also, remove a completed TODO.

Change-Id: I0eb4439272fad9ccb5fe8e2cf409fdd5dc15b26e
Reviewed-on: https://go-review.googlesource.com/43463
Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
src/cmd/compile/internal/ssa/html.go

index e98c5dc46002dd03b8b2989311b78e56fce433bf..d554907bebe541b9a6dddbdc82ebea92869150a9 100644 (file)
@@ -142,13 +142,13 @@ dd.ssa-prog {
 <script type="text/javascript">
 // ordered list of all available highlight colors
 var highlights = [
-    "highlight-yellow",
     "highlight-aquamarine",
     "highlight-coral",
     "highlight-lightpink",
     "highlight-lightsteelblue",
     "highlight-palegreen",
-    "highlight-lightgray"
+    "highlight-lightgray",
+    "highlight-yellow"
 ];
 
 // state: which value is highlighted this color?
@@ -264,8 +264,6 @@ function toggle_visibility(id) {
 </script>
 
 </head>`)
-       // TODO: Add javascript click handlers for blocks
-       // to outline that block across all phases
        w.WriteString("<body>")
        w.WriteString("<h1>")
        w.WriteString(html.EscapeString(name))