lib/codereview: allow addca CLs without LGTM

LGTM=gri
R=golang-codereviews, gri
CC=golang-codereviews
https://golang.org/cl/61610043

diff --git a/lib/codereview/codereview.py b/lib/codereview/codereview.py
index 2618ef930186cad51ebb21f87ad95e7068630db2..d171ef3e9914edfa15b526681e4d8345ef1bd46b 100644 (file)
--- a/lib/codereview/codereview.py
+++ b/lib/codereview/codereview.py
@@ -1935,7 +1935,7 @@ def submit(ui, repo, *pats, **opts):
 
        about = ""
 
-       if not cl.lgtm and not opts.get('tbr'):
+       if not cl.lgtm and not opts.get('tbr') and not isAddca(cl):
                raise hg_util.Abort("this CL has not been LGTM'ed")
        if cl.lgtm:
                about += "LGTM=" + JoinComma([CutDomain(who) for (who, line, approval) in cl.lgtm if approval]) + "\n"
@@ -2050,6 +2050,11 @@ def submit(ui, repo, *pats, **opts):
                        return err
        return 0
 
+def isAddca(cl):
+       rev = cl.reviewer
+       isGobot = 'gobot' in rev or 'gobot@swtch.com' in rev or 'gobot@golang.org' in rev
+       return cl.desc.startswith('A+C:') and 'Generated by addca.' in cl.desc and isGobot
+
 #######################################################################
 # hg sync