]> Cypherpunks repositories - gostls13.git/commitdiff
cmd/dist: document why test fails on incomplete ports
authorTobias Klauser <tklauser@distanz.ch>
Sat, 24 Oct 2020 18:21:48 +0000 (20:21 +0200)
committerTobias Klauser <tobias.klauser@gmail.com>
Sat, 24 Oct 2020 22:08:35 +0000 (22:08 +0000)
It might not be obvious from reading the code why we consider the test
as failed on incomplete ports even though it passed. Add a comment
documenting this behavior, as suggested by Dmitri in CL 155839.

Change-Id: I3eb7db27d01d63db277172381e5fa51577dad941
Reviewed-on: https://go-review.googlesource.com/c/go/+/264682
Trust: Tobias Klauser <tobias.klauser@gmail.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
src/cmd/dist/test.go

index 09d69f72ed6cdfe17a4aac6a2c2370efb07a9ff4..dbe55a7c3865279a9b51b43627a6d53edb8b3847 100644 (file)
@@ -217,6 +217,9 @@ func (t *tester) run() {
                fmt.Println("\nFAILED")
                xexit(1)
        } else if incomplete[goos+"/"+goarch] {
+               // The test succeeded, but consider it as failed so we don't
+               // forget to remove the port from the incomplete map once the
+               // port is complete.
                fmt.Println("\nFAILED (incomplete port)")
                xexit(1)
        } else if t.partial {