]> Cypherpunks repositories - gostls13.git/commitdiff
runtime: relax TestWindowsStackMemory from 100kB to 128kB
authorRuss Cox <rsc@golang.org>
Sun, 17 Nov 2024 15:20:18 +0000 (10:20 -0500)
committerGopher Robot <gobot@golang.org>
Mon, 18 Nov 2024 02:08:17 +0000 (02:08 +0000)
We've been getting intermittent flakes in this test since 2023,
all reporting values just barely over 100kB on windows-386.

If we were happy with 100kB, we should be happy with 128kB,
and it should fix the flakes.

Fixes #58570.

Change-Id: Iabe734cfbba6fe28a83f62e7811ee03fed424f0b
Reviewed-on: https://go-review.googlesource.com/c/go/+/628795
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Russ Cox <rsc@golang.org>
Reviewed-by: Cherry Mui <cherryyz@google.com>
src/runtime/syscall_windows_test.go

index edbc453ec8d9bc94979703db29dc58070a8be490..01a9ca3b8cfba8a20f0039500c66b63142b4bb8c 100644 (file)
@@ -673,7 +673,7 @@ func TestWindowsStackMemory(t *testing.T) {
        if err != nil {
                t.Fatalf("Failed to read stack usage: %v", err)
        }
-       if expected, got := 100<<10, stackUsage; got > expected {
+       if expected, got := 128<<10, stackUsage; got > expected {
                t.Fatalf("expected < %d bytes of memory per thread, got %d", expected, got)
        }
 }