]> Cypherpunks repositories - gostls13.git/commitdiff
net/http: disable new flaky TestTransportCancelBeforeResponseHeaders test
authorBrad Fitzpatrick <bradfitz@golang.org>
Mon, 27 Jul 2015 22:01:16 +0000 (00:01 +0200)
committerBrad Fitzpatrick <bradfitz@golang.org>
Tue, 28 Jul 2015 05:36:52 +0000 (05:36 +0000)
I'll rewrite this later. It's apparently dependent on scheduling order.
The earlier fix in git rev 9d56c181 seems fine, though.

Update #11894

Change-Id: I7c150918af4be079c262a5f2933ef4639cc535ef
Reviewed-on: https://go-review.googlesource.com/12731
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Andrew Gerrand <adg@golang.org>
src/net/http/transport_test.go

index 0950d2de2346d8211b37c0ef540bda72ee792dd2..c21d4afa87f1ecfe6997d9fef38dc6d380f516aa 100644 (file)
@@ -1554,6 +1554,7 @@ func TestCancelRequestWithChannelBeforeDo(t *testing.T) {
 
 // Issue 11020. The returned error message should be errRequestCanceled
 func TestTransportCancelBeforeResponseHeaders(t *testing.T) {
+       t.Skip("Skipping flaky test; see Issue 11894")
        defer afterTest(t)
 
        serverConnCh := make(chan net.Conn, 1)