]> Cypherpunks repositories - gostls13.git/commitdiff
os: do not test Lstat in TestDevNullFile
authorAlex Brainman <alex.brainman@gmail.com>
Mon, 26 Mar 2018 08:28:51 +0000 (19:28 +1100)
committerAlex Brainman <alex.brainman@gmail.com>
Mon, 26 Mar 2018 09:23:22 +0000 (09:23 +0000)
CL 102456 added Lstat check to TestDevNullFile.
But some systems have /dev/null as a symlink,
so Lstat test is wrong. Remove the test.

Fixes #24521

Change-Id: I149110b08dd05db6495ec4eccbcf943e444332f9
Reviewed-on: https://go-review.googlesource.com/102461
Run-TryBot: Alex Brainman <alex.brainman@gmail.com>
Reviewed-by: Tobias Klauser <tobias.klauser@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>

src/os/os_test.go

index 38cbfca272c8c5d0b783c6cfda47a68f2f203f1c..388673938962e566bc5eebbef3071aaee53d03ad 100644 (file)
@@ -1835,12 +1835,6 @@ func testDevNullFile(t *testing.T, devNullName string, ignoreCase bool) {
                t.Fatalf("Stat(%s): %v", devNullName, err)
        }
        testDevNullFileInfo(t, "Stat", devNullName, fi, ignoreCase)
-
-       fi, err = Lstat(devNullName)
-       if err != nil {
-               t.Fatalf("Lstat(%s): %v", devNullName, err)
-       }
-       testDevNullFileInfo(t, "Lstat", devNullName, fi, ignoreCase)
 }
 
 func TestDevNullFile(t *testing.T) {