]> Cypherpunks repositories - gostls13.git/commitdiff
net: unskip TestUDPZeroBytePayload on Darwin
authorDmitri Shuralyov <dmitshur@golang.org>
Fri, 26 Jul 2024 16:49:29 +0000 (12:49 -0400)
committerGopher Robot <gobot@golang.org>
Fri, 26 Jul 2024 17:39:51 +0000 (17:39 +0000)
From information we have available in the issue, this test was flaky
on OS X 10.10 but not newer. By now macOS 11 is the minimum required
version, and 1000 local runs of the test passed, so try to unskip as
the next step.

For #29225.

Change-Id: I18a24459f01e53ef9de05b50d1dd8786d0683107
Cq-Include-Trybots: luci.golang.try:gotip-darwin-amd64_11,gotip-darwin-amd64_14
Reviewed-on: https://go-review.googlesource.com/c/go/+/601395
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
src/net/udpsock_test.go

index 8a21aa737055ede2556a3725e95db8804ca4976b..43065d06dab7719b53718a0ef6f067242b59c9f1 100644 (file)
@@ -340,7 +340,7 @@ func TestUDPZeroBytePayload(t *testing.T) {
        switch runtime.GOOS {
        case "plan9":
                t.Skipf("not supported on %s", runtime.GOOS)
-       case "darwin", "ios":
+       case "ios":
                testenv.SkipFlaky(t, 29225)
        }
        if !testableNetwork("udp") {