]> Cypherpunks repositories - gostls13.git/commitdiff
crypto/tls/internal/fips140tls: use crypto/fips140
authorqmuntal <quimmuntal@gmail.com>
Fri, 10 Jan 2025 12:38:35 +0000 (13:38 +0100)
committerQuim Muntal <quimmuntal@gmail.com>
Thu, 13 Mar 2025 21:01:46 +0000 (14:01 -0700)
There is no need for fips140tls to depend on an internal package, it
can use crypto/fips140 directly.

Both approaches are equivalent, but using crypto/fips140 makes us
exercise a public API and sets precedence.

Change-Id: I668e80ee62b711bc60821cee3a54232a33295ee1
Reviewed-on: https://go-review.googlesource.com/c/go/+/642035
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: David Chase <drchase@google.com>
Reviewed-by: Filippo Valsorda <filippo@golang.org>
Reviewed-by: Junyang Shao <shaojunyang@google.com>
src/crypto/tls/internal/fips140tls/fipstls.go
src/go/build/deps_test.go

index 24d78d60cf5b64adb6e3542cfb29c8f9eabc9800..0b87185683ab8b31f732127f1a4ffb140f2df356 100644 (file)
@@ -6,14 +6,14 @@
 package fips140tls
 
 import (
-       "crypto/internal/fips140"
+       "crypto/fips140"
        "sync/atomic"
 )
 
 var required atomic.Bool
 
 func init() {
-       if fips140.Enabled {
+       if fips140.Enabled() {
                Force()
        }
 }
index 580500c033e1fc098d9e48deaca26a6a22d48d32..c355cb42f7ec3bfe02a0272002da2fa58073d552 100644 (file)
@@ -552,7 +552,7 @@ var depsRules = `
 
        # TLS, Prince of Dependencies.
 
-       FIPS, sync/atomic < crypto/tls/internal/fips140tls;
+       crypto/fips140, sync/atomic < crypto/tls/internal/fips140tls;
 
        crypto/internal/boring/sig, crypto/tls/internal/fips140tls < crypto/tls/fipsonly;