]> Cypherpunks repositories - gostls13.git/commitdiff
cmd/go: test that 'go list -e -mod=readonly' reports errors correctly
authorJay Conrod <jayconrod@google.com>
Tue, 26 Nov 2019 22:07:26 +0000 (17:07 -0500)
committerJay Conrod <jayconrod@google.com>
Thu, 5 Dec 2019 20:14:44 +0000 (20:14 +0000)
This issue was fixed by earlier improvements to error handling when
loading modules.

Fixes #34829

Change-Id: I4cf4e182a7381f8b5c359179d90bd02491ea7911
Reviewed-on: https://go-review.googlesource.com/c/go/+/209037
Run-TryBot: Jay Conrod <jayconrod@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
src/cmd/go/testdata/script/mod_list_e_readonly.txt [new file with mode: 0644]

diff --git a/src/cmd/go/testdata/script/mod_list_e_readonly.txt b/src/cmd/go/testdata/script/mod_list_e_readonly.txt
new file mode 100644 (file)
index 0000000..5baeea2
--- /dev/null
@@ -0,0 +1,15 @@
+# 'go list -mod=readonly -e should attribute errors
+# to individual missing packages.
+# Verifies golang.org/issue/34829.
+go list -mod=readonly -e -deps -f '{{if .Error}}{{.ImportPath}}: {{.Error}}{{end}}' .
+stdout 'example.com/missing: use.go:3:8: import lookup disabled by -mod=readonly'
+
+-- go.mod --
+module example.com/m
+
+go 1.14
+
+-- use.go --
+package use
+
+import _ "example.com/missing"