]> Cypherpunks repositories - gostls13.git/commitdiff
math/cmplx: disable TanHuge test on s390x
authorBrian Kessler <brian.m.kessler@gmail.com>
Sat, 14 Mar 2020 06:37:20 +0000 (00:37 -0600)
committerRob Pike <r@golang.org>
Sat, 14 Mar 2020 07:03:15 +0000 (07:03 +0000)
s390x has inaccurate range reduction for the assembly routines
in math so these tests are diabled until these are corrected.

Updates #37854

Change-Id: I1e26acd6d09ae3e592a3dd90aec73a6844f5c6fe
Reviewed-on: https://go-review.googlesource.com/c/go/+/223457
Run-TryBot: Brian Kessler <brian.m.kessler@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Rob Pike <r@golang.org>
src/math/cmplx/cmath_test.go
src/math/cmplx/huge_test.go [new file with mode: 0644]

index 1b076c881ca84a0b2feed7287ace7c46c03a84d8..d934ba5e57a360bc1e08baa678ec2d7f26edb548 100644 (file)
@@ -834,11 +834,6 @@ func TestTan(t *testing.T) {
                        t.Errorf("Tan(%g) = %g, want %g", vc[i], f, tan[i])
                }
        }
-       for i, x := range hugeIn {
-               if f := Tan(x); !cSoclose(tanHuge[i], f, 3e-15) {
-                       t.Errorf("Tan(%g) = %g, want %g", x, f, tanHuge[i])
-               }
-       }
        for i := 0; i < len(vcTanSC); i++ {
                if f := Tan(vcTanSC[i]); !cAlike(tanSC[i], f) {
                        t.Errorf("Tan(%g) = %g, want %g", vcTanSC[i], f, tanSC[i])
diff --git a/src/math/cmplx/huge_test.go b/src/math/cmplx/huge_test.go
new file mode 100644 (file)
index 0000000..f8e60c2
--- /dev/null
@@ -0,0 +1,22 @@
+// Copyright 2020 The Go Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style
+// license that can be found in the LICENSE file.
+
+// Disabled for s390x because it uses assembly routines that are not
+// accurate for huge arguments.
+
+// +build !s390x
+
+package cmplx
+
+import (
+       "testing"
+)
+
+func TestTanHuge(t *testing.T) {
+       for i, x := range hugeIn {
+               if f := Tan(x); !cSoclose(tanHuge[i], f, 3e-15) {
+                       t.Errorf("Tan(%g) = %g, want %g", x, f, tanHuge[i])
+               }
+       }
+}