internal/buildcfg: fix test for GOAMD64=v3 ./all.bash

If GOAMD64 is set to a bogus value, goamd64() will return the default
value, which may not necessarily be 1. Instead, just test that it sets
Error.

Change-Id: Ibbc26608c1ae24e645c7753ef5765b9c2fdc089e
Reviewed-on: https://go-review.googlesource.com/c/go/+/351129
Trust: Matthew Dempsky <mdempsky@google.com>
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>

diff --git a/src/internal/buildcfg/cfg_test.go b/src/internal/buildcfg/cfg_test.go
index 9180441c28cc03db1a17713ed891267e3d269c37..0123593317d4319bf94ee3c12d7a910a5c35c13d 100644 (file)
--- a/src/internal/buildcfg/cfg_test.go
+++ b/src/internal/buildcfg/cfg_test.go
@@ -18,8 +18,9 @@ func TestConfigFlags(t *testing.T) {
        if goamd64() != 4 {
                t.Errorf("Wrong parsing of GOAMD64=v4")
        }
+       Error = nil
        os.Setenv("GOAMD64", "1")
-       if goamd64() != 1 {
+       if goamd64(); Error == nil {
                t.Errorf("Wrong parsing of GOAMD64=1")
        }
 }