]> Cypherpunks repositories - gostls13.git/commitdiff
runtime: fix GDB tests on s390x running Ubuntu 18.04
authorMichael Munday <mike.munday@ibm.com>
Thu, 28 Mar 2019 12:05:43 +0000 (08:05 -0400)
committerMichael Munday <mike.munday@ibm.com>
Mon, 15 Apr 2019 14:53:19 +0000 (14:53 +0000)
On Ubuntu 18.04 I am seeing GDB fail to restore the stack pointer
during this test because stack unwinding can't find the PC. This CL
is essentially a partial revert of CL 23940 and fixes the issue on
s390x.

Change-Id: Ib4c41162dc85dc882eb6e248330f4082c3fa94c3
Reviewed-on: https://go-review.googlesource.com/c/go/+/169857
Run-TryBot: Cherry Zhang <cherryyz@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
src/runtime/runtime-gdb.py

index 48960b7f6133f5d5ed4d12ba0b0b5d3279a35f12..72645d289e646df4f80afdfe73c0b7188e0a8559 100644 (file)
@@ -540,8 +540,8 @@ class GoroutineCmd(gdb.Command):
                        # In GDB, assignments to sp must be done from the
                        # top-most frame, so select frame 0 first.
                        gdb.execute('select-frame 0')
-                       gdb.parse_and_eval('$sp = $save_sp')
                        gdb.parse_and_eval('$pc = $save_pc')
+                       gdb.parse_and_eval('$sp = $save_sp')
                        save_frame.select()