]> Cypherpunks repositories - gostls13.git/commitdiff
go/types: fix bad printf verbs
authorJosh Bleecher Snyder <josharian@gmail.com>
Fri, 8 Jul 2016 00:20:00 +0000 (17:20 -0700)
committerJosh Bleecher Snyder <josharian@gmail.com>
Tue, 16 Aug 2016 00:24:37 +0000 (00:24 +0000)
This fixes the following vet warnings:

go/types/builtins.go:437: arg call for printf verb %s of wrong type: *go/ast.CallExpr
go/types/builtins.go:598: arg call for printf verb %s of wrong type: *go/ast.CallExpr

Updates #11041

Change-Id: I746d054e8e49b330fbdf961912a98f55dd5f3ff9
Reviewed-on: https://go-review.googlesource.com/26997
Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Robert Griesemer <gri@golang.org>
src/go/types/builtins.go

index 0082be9e2e95fd266679496cbe1d3f87035646f4..fc4db4513b8af2eabd2ecbeb0518cbe614c83c92 100644 (file)
@@ -434,7 +434,7 @@ func (check *Checker) builtin(x *operand, call *ast.CallExpr, id builtinId) (_ b
                        return
                }
                if nargs < min || min+1 < nargs {
-                       check.errorf(call.Pos(), "%s expects %d or %d arguments; found %d", call, min, min+1, nargs)
+                       check.errorf(call.Pos(), "%v expects %d or %d arguments; found %d", call, min, min+1, nargs)
                        return
                }
                var sizes []int64 // constant integer arguments, if any
@@ -595,7 +595,7 @@ func (check *Checker) builtin(x *operand, call *ast.CallExpr, id builtinId) (_ b
                        return
                }
                if !constant.BoolVal(x.val) {
-                       check.errorf(call.Pos(), "%s failed", call)
+                       check.errorf(call.Pos(), "%v failed", call)
                        // compile-time assertion failure - safe to continue
                }
                // result is constant - no need to record signature