]> Cypherpunks repositories - gostls13.git/commitdiff
runtime: temporarily skip gdb python-related tests on illumos
authorJoshua M. Clulow <josh@sysmgr.org>
Mon, 21 Oct 2019 08:45:43 +0000 (01:45 -0700)
committerBrad Fitzpatrick <bradfitz@golang.org>
Mon, 21 Oct 2019 05:11:52 +0000 (05:11 +0000)
Updates golang/go#20821

Change-Id: I186356a78ac385a15b4604e0ea6110c4c212ebc4
Reviewed-on: https://go-review.googlesource.com/c/go/+/202357
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
src/runtime/runtime-gdb_test.go

index de1bac65daf7fc15f9b6df0bd962b62be1463412..8cbc7638ca7c89319082909afaf55b4088e843a1 100644 (file)
@@ -66,8 +66,8 @@ func checkGdbVersion(t *testing.T) {
 }
 
 func checkGdbPython(t *testing.T) {
-       if runtime.GOOS == "solaris" && testenv.Builder() != "solaris-amd64-smartosbuildlet" {
-               t.Skip("skipping gdb python tests on solaris; see golang.org/issue/20821")
+       if runtime.GOOS == "solaris" || runtime.GOOS == "illumos" {
+               t.Skip("skipping gdb python tests on illumos and solaris; see golang.org/issue/20821")
        }
 
        cmd := exec.Command("gdb", "-nx", "-q", "--batch", "-iex", "python import sys; print('go gdb python support')")