]> Cypherpunks repositories - gostls13.git/commitdiff
net/http: change TestServerAllowsBlockingRemoteAddr to non-parallel
authorJosh Bleecher Snyder <josharian@gmail.com>
Fri, 10 Mar 2017 06:02:13 +0000 (22:02 -0800)
committerBrad Fitzpatrick <bradfitz@golang.org>
Fri, 10 Mar 2017 18:46:54 +0000 (18:46 +0000)
It appears that this test is particularly
sensitive to resource starvation.
Returning it to non-parallel should reduce flakiness,
by giving it the full system resources to run.

Fixes #19161

Change-Id: I6e8906516629badaa0cffeb5712af649dc197f39
Reviewed-on: https://go-review.googlesource.com/38005
Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
src/net/http/serve_test.go

index d301d15eb1b49bf018bca88bbc583c2f2e01fe4d..7d964b309eac4040a6e1e0c2ac6d6915017243ea 100644 (file)
@@ -929,7 +929,6 @@ func (c *blockingRemoteAddrConn) RemoteAddr() net.Addr {
 
 // Issue 12943
 func TestServerAllowsBlockingRemoteAddr(t *testing.T) {
-       setParallel(t)
        defer afterTest(t)
        ts := httptest.NewUnstartedServer(HandlerFunc(func(w ResponseWriter, r *Request) {
                fmt.Fprintf(w, "RA:%s", r.RemoteAddr)