all: simplify bool conditions

Change-Id: Id2079f7012392dea8dfe2386bb9fb1ea3f487a4a
Reviewed-on: https://go-review.googlesource.com/c/go/+/526015
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
Auto-Submit: Ian Lance Taylor <iant@google.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: qiulaidongfeng <2645477756@qq.com>

diff --git a/src/crypto/sha1/fallback_test.go b/src/crypto/sha1/fallback_test.go
index 45d1f57d39cfd352d678c07e69e3dfb9658d2f6f..aa1d413f2f063f31a72e079fbd3c094e3f3f0b76 100644 (file)
--- a/src/crypto/sha1/fallback_test.go
+++ b/src/crypto/sha1/fallback_test.go
@@ -16,7 +16,7 @@ import (
 // implementation cannot be used.
 // See also TestBlockGeneric.
 func TestGenericPath(t *testing.T) {
-       if useAsm == false {
+       if !useAsm {
                t.Skipf("assembly implementation unavailable")
        }
        useAsm = false

diff --git a/src/crypto/sha512/fallback_test.go b/src/crypto/sha512/fallback_test.go
index db5b13c38c4f080cd179dac7bb9bd183e47f9965..ac0c2c3c76f712d38637444c557669f578513f59 100644 (file)
--- a/src/crypto/sha512/fallback_test.go
+++ b/src/crypto/sha512/fallback_test.go
@@ -16,7 +16,7 @@ import (
 // implementation cannot be used.
 // See also TestBlockGeneric.
 func TestGenericPath(t *testing.T) {
-       if useAsm == false {
+       if !useAsm {
                t.Skipf("assembly implementation unavailable")
        }
        useAsm = false

diff --git a/src/database/sql/sql_test.go b/src/database/sql/sql_test.go
index f1c946d4e46929af8d0084a3ac4df909684d9bf1..c38a348ab4f88fee53bdd5cce2973522250e6f71 100644 (file)
--- a/src/database/sql/sql_test.go
+++ b/src/database/sql/sql_test.go
@@ -3769,7 +3769,7 @@ func TestIssue18719(t *testing.T) {
                cancel()
 
                // Wait for the context to cancel and tx to rollback.
-               for tx.isDone() == false {
+               for !tx.isDone() {
                        time.Sleep(pollDuration)
                }
        }

diff --git a/src/math/big/arith_s390x_test.go b/src/math/big/arith_s390x_test.go
index 8375ddbdd4c8c4409a5f231083816c3aefcad639..093984b397e88f3a0ed629ec01bbf872cd015fde 100644 (file)
--- a/src/math/big/arith_s390x_test.go
+++ b/src/math/big/arith_s390x_test.go
@@ -15,7 +15,7 @@ import (
 // vector-capable machine
 
 func TestFunVVnovec(t *testing.T) {
-       if hasVX == true {
+       if hasVX {
                for _, a := range sumVV {
                        arg := a
                        testFunVV(t, "addVV_novec", addVV_novec, arg)

diff --git a/src/net/http/response_test.go b/src/net/http/response_test.go
index ddd318084db4733b4fcb21737e825f6656c7bb3f..f3425c3c2046aca5ceeb8b949b0cfb97eb509cbf 100644 (file)
--- a/src/net/http/response_test.go
+++ b/src/net/http/response_test.go
@@ -849,7 +849,7 @@ func TestReadResponseErrors(t *testing.T) {
        type testCase struct {
                name    string // optional, defaults to in
                in      string
-               wantErr any // nil, err value, or string substring
+               wantErr any // nil, err value, bool value, or string substring
        }
 
        status := func(s string, wantErr any) testCase {