Revert "fmt: add a few more reflect.Value tests"

This reverts commit 3e6b7f35de96414a3a393f0ad25326f411101776.

Change-Id: Icad2b235b9880729fbdf80d7dfd71e56df4b1231
Reviewed-on: https://go-review.googlesource.com/8944
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>

diff --git a/src/fmt/fmt_test.go b/src/fmt/fmt_test.go
index 948df3579cbd968c99957011d931e3397a1bc9c6..96505b82716abc926aaf72641ad3ca7e56735aa4 100644 (file)
--- a/src/fmt/fmt_test.go
+++ b/src/fmt/fmt_test.go
@@ -686,14 +686,6 @@ var fmtTests = []struct {
        // Issue 8965.
        {"%v", reflect.ValueOf(A{}).Field(0).String(), "<int Value>"}, // Equivalent to the old way.
        {"%v", reflect.ValueOf(A{}).Field(0), "0"},                    // Sees inside the field.
-
-       // verbs apply to the extracted value too.
-       {"%s", reflect.ValueOf("hello"), "hello"},
-       {"%q", reflect.ValueOf("hello"), `"hello"`},
-       {"%#04x", reflect.ValueOf(256), "0x0100"},
-
-       // invalid reflect.Value doesn't crash.
-       {"%v", reflect.Value{}, "<nil>"},
 }
 
 // zeroFill generates zero-filled strings of the specified width. The length

diff --git a/src/fmt/print.go b/src/fmt/print.go
index 8e35a890ec9f2c95740232081aae4fc9bdc1d2ee..c8038f09a8818b7ed0457a6387d1f3531aeabb7d 100644 (file)
--- a/src/fmt/print.go
+++ b/src/fmt/print.go
@@ -847,8 +847,6 @@ func (p *pp) printReflectValue(value reflect.Value, verb rune, depth int) (wasSt
        p.value = value
 BigSwitch:
        switch f := value; f.Kind() {
-       case reflect.Invalid:
-               p.buf.WriteString("<invalid reflect.Value>")
        case reflect.Bool:
                p.fmtBool(f.Bool(), verb)
        case reflect.Int, reflect.Int8, reflect.Int16, reflect.Int32, reflect.Int64: