]> Cypherpunks repositories - gostls13.git/commitdiff
strings: clarify example of ContainsAny
authorMartin Sucha <anty.sk+git@gmail.com>
Thu, 23 May 2019 18:34:17 +0000 (20:34 +0200)
committerBrad Fitzpatrick <bradfitz@golang.org>
Fri, 24 May 2019 15:23:08 +0000 (15:23 +0000)
I have seen code that literally copied the example like this:

    if strings.ContainsAny(s, "1 & 2 & 3") {

The developer apparently thought that this is the way to
specify multiple characters and I noticed this pattern
being used in the example. Let's update the example so
that it's clear how multiple Unicode code points should
be specified.

Change-Id: Id4d780555e521af62fb787a7950be1e60848cd95
Reviewed-on: https://go-review.googlesource.com/c/go/+/178737
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>

src/strings/example_test.go

index e31054a4e0b31355e51ed3d2f904d785bc688503..4f3a1ce8c6fdf869eb20b383d6a8ab98102a62b4 100644 (file)
@@ -47,12 +47,16 @@ func ExampleContains() {
 
 func ExampleContainsAny() {
        fmt.Println(strings.ContainsAny("team", "i"))
-       fmt.Println(strings.ContainsAny("failure", "u & i"))
+       fmt.Println(strings.ContainsAny("fail", "ui"))
+       fmt.Println(strings.ContainsAny("ure", "ui"))
+       fmt.Println(strings.ContainsAny("failure", "ui"))
        fmt.Println(strings.ContainsAny("foo", ""))
        fmt.Println(strings.ContainsAny("", ""))
        // Output:
        // false
        // true
+       // true
+       // true
        // false
        // false
 }