]> Cypherpunks repositories - gostls13.git/commitdiff
cmd/go: fix test when go source tree has POSIX ACL
authorJess Frazelle <me@jessfraz.com>
Thu, 20 Jul 2017 16:29:15 +0000 (12:29 -0400)
committerIan Lance Taylor <iant@golang.org>
Thu, 20 Jul 2017 18:42:59 +0000 (18:42 +0000)
Fixes TestGoBuildUmask when the user has a POSIX ACL on the Go source tree.

Fixes #17909.

Change-Id: I5bc19099af8353afd41071258f4f317612b4c8c1
Reviewed-on: https://go-review.googlesource.com/50370
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>

src/cmd/go/go_unix_test.go

index c445a2ec73b1b844bf3f346059e8f66698a33db6..f6e10ca59c743f8a2f26bcdbea731196c0259d86 100644 (file)
@@ -19,9 +19,13 @@ func TestGoBuildUmask(t *testing.T) {
        tg := testgo(t)
        defer tg.cleanup()
        tg.tempFile("x.go", `package main; func main() {}`)
-       tg.creatingTemp("x")
-       tg.run("build", tg.path("x.go"))
-       fi, err := os.Stat("x")
+       // Make sure artifact will be output to /tmp/... in case the user
+       // has POSIX acl's on their go source tree.
+       // See issue 17909.
+       exe := tg.path("x")
+       tg.creatingTemp(exe)
+       tg.run("build", "-o", exe, tg.path("x.go"))
+       fi, err := os.Stat(exe)
        if err != nil {
                t.Fatal(err)
        }