]> Cypherpunks repositories - gostls13.git/commitdiff
runtime: skip TestSegv/SegvInCgo earlier on ios
authorBryan C. Mills <bcmills@google.com>
Wed, 3 May 2023 15:22:53 +0000 (11:22 -0400)
committerBryan Mills <bcmills@google.com>
Thu, 4 May 2023 16:23:46 +0000 (16:23 +0000)
It appears to sometimes hang instead of crashing,
which can cause subsequent tests to time out.

For #59947.

Change-Id: Id4ac3c0cd5f7f345334d3e0ed3f48e40b9ff191c
Reviewed-on: https://go-review.googlesource.com/c/go/+/492075
TryBot-Result: Gopher Robot <gobot@golang.org>
Auto-Submit: Bryan Mills <bcmills@google.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
Run-TryBot: Bryan Mills <bcmills@google.com>

src/runtime/crash_cgo_test.go

index f771493b1a81ff38c5d49ff4a90390780695a13d..9efe202085d354898df7c908e12e527867cf7fb0 100644 (file)
@@ -643,6 +643,10 @@ func TestSegv(t *testing.T) {
                }
 
                t.Run(test, func(t *testing.T) {
+                       if test == "SegvInCgo" && runtime.GOOS == "ios" {
+                               testenv.SkipFlaky(t, 59947) // Don't even try, in case it times out.
+                       }
+
                        t.Parallel()
                        got := runTestProg(t, "testprogcgo", test)
                        t.Log(got)