]> Cypherpunks repositories - gostls13.git/commitdiff
net: skip TestUnixConnLocalWindows on windows/386
authorAlex Brainman <alex.brainman@gmail.com>
Sun, 30 Sep 2018 06:07:27 +0000 (16:07 +1000)
committerAlex Brainman <alex.brainman@gmail.com>
Tue, 2 Oct 2018 09:49:44 +0000 (09:49 +0000)
Recent CL 125456 implemented Unix Socket functionality on windows.
But that functionality does not appear to be working when 32-bit
code is used. So disable TestUnixConnLocalWindows.

windows/386 builder does not appear to be complaining about
TestUnixConnLocalWindows, because new functionality requires
Windows 10 Build 17063. windows/386 builder uses Windows 2008.

Fixes #27943

Change-Id: Iea91b86aaa124352d198ca0cd03fff1e7542f949
Reviewed-on: https://go-review.googlesource.com/138676
Run-TryBot: Alex Brainman <alex.brainman@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Yasuhiro MATSUMOTO <mattn.jp@gmail.com>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
src/net/unixsock_windows_test.go

index a1da5d4062d41eb7e03d63267a4d44b3f5044482..d856e3fd815697e9899164934bca64cad0d55878 100644 (file)
@@ -10,6 +10,7 @@ import (
        "internal/syscall/windows/registry"
        "os"
        "reflect"
+       "runtime"
        "strconv"
        "testing"
 )
@@ -33,6 +34,9 @@ func isBuild17063() bool {
 }
 
 func TestUnixConnLocalWindows(t *testing.T) {
+       if runtime.GOARCH == "386" {
+               t.Skip("not supported on windows/386, see golang.org/issue/27943")
+       }
        if !isBuild17063() {
                t.Skip("unix test")
        }