]> Cypherpunks repositories - gostls13.git/commitdiff
cmd/compile/internal/staticinit: remove FIPS debugging
authorRuss Cox <rsc@golang.org>
Fri, 15 Nov 2024 14:34:04 +0000 (09:34 -0500)
committerGopher Robot <gobot@golang.org>
Fri, 15 Nov 2024 16:06:27 +0000 (16:06 +0000)
This is panicking on the darwin-amd64-longtest builders.
Not sure why, but it was added only to get a stack trace
during debugging. If there's still a problem, we should let
it proceed and find the real problem.

The test that was failing - internal/coverage/cfile - passes
with this CL, even when I set GODEBUG=fips140=on,
so there's hope that it will fix the longtest builders.

Change-Id: I9b3e743effdddcc0a76895922f87631527781dff
Reviewed-on: https://go-review.googlesource.com/c/go/+/628375
Reviewed-by: Sam Thanawalla <samthanawalla@google.com>
Auto-Submit: Russ Cox <rsc@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>

src/cmd/compile/internal/staticinit/sched.go

index e013823ee71267d352029ff1b98ba195eb0b888c..fae4eb0d8b7d4c5e2d5727d4d2ed2f22b3cb4df1 100644 (file)
@@ -767,9 +767,6 @@ var statuniqgen int // name generator for static temps
 func StaticName(t *types.Type) *ir.Name {
        // Don't use LookupNum; it interns the resulting string, but these are all unique.
        sym := typecheck.Lookup(fmt.Sprintf("%s%d", obj.StaticNamePrefix, statuniqgen))
-       if sym.Name == ".stmp_0" && sym.Pkg.Path == "crypto/internal/fips/check" {
-               panic("bad")
-       }
        statuniqgen++
 
        n := ir.NewNameAt(base.Pos, sym, t)