]> Cypherpunks repositories - gostls13.git/commitdiff
runtime: Allow handling of EXCEPTION_IN_PAGE_ERROR
authorMax Altgelt <max.altgelt@nextron-systems.com>
Fri, 10 Feb 2023 10:38:42 +0000 (11:38 +0100)
committerQuim Muntal <quimmuntal@gmail.com>
Sat, 11 Feb 2023 09:26:59 +0000 (09:26 +0000)
Currently, access faults on memory mapped files on Windows (e.g.
from the drive the memory mapped file is on being ejected) cause
a runtime fault that can not be caught by debug.SetPanicOnFault.

On Unix systems, on the other hand, this causes a SIGBUS signal,
which can be caught by debug.SetPanicOnFault. Given that the
documentation of debug.SetPanicOnFault mentions handling memory
mapped files, this is arguably the correct behaviour.

Add handling, analogous to SIGBUS, to EXCEPTION_IN_PAGE_ERROR
on Windows, to allow for users to handle this error.

Fixes #58457

Change-Id: Ic7695fc01271f3552782089ac75c403d5279811f
Reviewed-on: https://go-review.googlesource.com/c/go/+/467195
Reviewed-by: David Chase <drchase@google.com>
Reviewed-by: Quim Muntal <quimmuntal@gmail.com>
Run-TryBot: David Chase <drchase@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Russ Cox <rsc@golang.org>
Reviewed-by: Alex Brainman <alex.brainman@gmail.com>
src/runtime/defs_windows.go
src/runtime/signal_windows.go

index 7e5d9570f80e64e62dcfcd17a8cf6ffeabafce4d..60f20a5c2cbe915e8e38c8e4f4d3daa1932ff6a0 100644 (file)
@@ -27,6 +27,7 @@ const (
        _CTRL_SHUTDOWN_EVENT = 0x6
 
        _EXCEPTION_ACCESS_VIOLATION     = 0xc0000005
+       _EXCEPTION_IN_PAGE_ERROR        = 0xc0000006
        _EXCEPTION_BREAKPOINT           = 0x80000003
        _EXCEPTION_ILLEGAL_INSTRUCTION  = 0xc000001d
        _EXCEPTION_FLT_DENORMAL_OPERAND = 0xc000008d
index 1ea0d1e06c470d02c0791f0a04ed178cdc4b8e87..e4258f01b0865e6fd3b32c4836371b4acf1cb381 100644 (file)
@@ -76,6 +76,7 @@ func isgoexception(info *exceptionrecord, r *context) bool {
        default:
                return false
        case _EXCEPTION_ACCESS_VIOLATION:
+       case _EXCEPTION_IN_PAGE_ERROR:
        case _EXCEPTION_INT_DIVIDE_BY_ZERO:
        case _EXCEPTION_INT_OVERFLOW:
        case _EXCEPTION_FLT_DENORMAL_OPERAND:
@@ -345,7 +346,7 @@ func sigpanic() {
        }
 
        switch gp.sig {
-       case _EXCEPTION_ACCESS_VIOLATION:
+       case _EXCEPTION_ACCESS_VIOLATION, _EXCEPTION_IN_PAGE_ERROR:
                if gp.sigcode1 < 0x1000 {
                        panicmem()
                }