cmd/internal/objabi: declare HeadType String on a non-pointer receiver

objabi.HeadType is typically used as a non-pointer type, however the String function
is declared on a pointer receiver. This means that in most cases its integer value
is printed, rather than the value from the String function.

Change-Id: I3d28d9680e88a714bc1152ed5e1df4ac43d7a33f
Reviewed-on: https://go-review.googlesource.com/c/go/+/430556
Run-TryBot: Cherry Mui <cherryyz@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Jenny Rakoczy <jenny@golang.org>
Reviewed-by: Cherry Mui <cherryyz@google.com>
Auto-Submit: Jenny Rakoczy <jenny@golang.org>

diff --git a/src/cmd/internal/objabi/head.go b/src/cmd/internal/objabi/head.go
index 48ff292307f477a24c8fd88d21b0aaca55960191..763910fbd6d2e804bcb895904cfb634e2a9aeada 100644 (file)
--- a/src/cmd/internal/objabi/head.go
+++ b/src/cmd/internal/objabi/head.go
@@ -80,8 +80,8 @@ func (h *HeadType) Set(s string) error {
        return nil
 }
 
-func (h *HeadType) String() string {
-       switch *h {
+func (h HeadType) String() string {
+       switch h {
        case Haix:
                return "aix"
        case Hdarwin:
@@ -105,5 +105,5 @@ func (h *HeadType) String() string {
        case Hwindows:
                return "windows"
        }
-       return fmt.Sprintf("HeadType(%d)", *h)
+       return fmt.Sprintf("HeadType(%d)", h)
 }