]> Cypherpunks repositories - gostls13.git/commitdiff
codereview: don't check default paths when codereview disabled
authorAndrew Gerrand <adg@golang.org>
Thu, 2 Feb 2012 19:25:13 +0000 (14:25 -0500)
committerRuss Cox <rsc@golang.org>
Thu, 2 Feb 2012 19:25:13 +0000 (14:25 -0500)
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5622043

lib/codereview/codereview.py

index 56ccb508dbcbcd8046896991274ddfc63ffe87b5..fd0b4b4aea52d41d5aaa5742571f912980653a47 100644 (file)
@@ -2187,10 +2187,6 @@ def reposetup(ui, repo):
        if codereview_init:
                return
        codereview_init = True
-       
-       remote = ui.config("paths", "default", "")
-       if remote.find("://") < 0:
-               raise hg_util.Abort("codereview: default path '%s' is not a URL" % (remote,))
 
        # Read repository-specific options from lib/codereview/codereview.cfg or codereview.cfg.
        root = ''
@@ -2200,7 +2196,7 @@ def reposetup(ui, repo):
                # Yes, repo might not have root; see issue 959.
                codereview_disabled = 'codereview disabled: repository has no root'
                return
-
+       
        repo_config_path = ''
        p1 = root + '/lib/codereview/codereview.cfg'
        p2 = root + '/codereview.cfg'
@@ -2220,6 +2216,10 @@ def reposetup(ui, repo):
                codereview_disabled = 'codereview disabled: cannot open ' + repo_config_path
                return
 
+       remote = ui.config("paths", "default", "")
+       if remote.find("://") < 0:
+               raise hg_util.Abort("codereview: default path '%s' is not a URL" % (remote,))
+
        InstallMatch(ui, repo)
        RietveldSetup(ui, repo)