]> Cypherpunks repositories - gostls13.git/commitdiff
net/netip: cover more AddrPort.String cases in tests
authorTobias Klauser <tklauser@distanz.ch>
Tue, 17 Sep 2024 08:42:08 +0000 (10:42 +0200)
committerGopher Robot <gobot@golang.org>
Wed, 18 Sep 2024 19:24:44 +0000 (19:24 +0000)
TestInvalidAddrPortString currently only tests for invalid AddrPorts.
Add some valid cases as well to improve test coverage.

Change-Id: Iaa9192e48a61daed6f7ce7d680d602a021570bdc
Reviewed-on: https://go-review.googlesource.com/c/go/+/613795
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Auto-Submit: Tobias Klauser <tobias.klauser@gmail.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
src/net/netip/netip_test.go

index e1a0a83f64511d97fc8681e024732bd032fd2abf..6067a1e6682b6e93760002150a14469c4c344311 100644 (file)
@@ -2179,11 +2179,14 @@ func TestPrefixString(t *testing.T) {
        }
 }
 
-func TestInvalidAddrPortString(t *testing.T) {
+func TestAddrPortString(t *testing.T) {
        tests := []struct {
                ipp  AddrPort
                want string
        }{
+               {MustParseAddrPort("127.0.0.1:80"), "127.0.0.1:80"},
+               {MustParseAddrPort("[0000::0]:8080"), "[::]:8080"},
+               {MustParseAddrPort("[FFFF::1]:8080"), "[ffff::1]:8080"},
                {AddrPort{}, "invalid AddrPort"},
                {AddrPortFrom(Addr{}, 80), "invalid AddrPort"},
        }