]> Cypherpunks repositories - gostls13.git/commitdiff
cmd/go: add a test for -sectcreate in LDFLAGS
authorSjoerd Siebinga <sjoerd.siebinga@gmail.com>
Thu, 22 Aug 2019 14:36:20 +0000 (16:36 +0200)
committerIan Lance Taylor <iant@golang.org>
Fri, 6 Sep 2019 17:34:02 +0000 (17:34 +0000)
It was already covered by a regex pattern, but it didn't have a test.

To fix the issue for good, added regression test.

Fixes #28832.

Change-Id: I861e3bed92d3b9484fd8671270dbd2e264b10d2d
Reviewed-on: https://go-review.googlesource.com/c/go/+/191311
Reviewed-by: Daniel Martí <mvdan@mvdan.cc>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Run-TryBot: Daniel Martí <mvdan@mvdan.cc>
TryBot-Result: Gobot Gobot <gobot@golang.org>

src/cmd/go/internal/work/security_test.go

index fd8caeab4ecf7dd0286ba26df65fb15dc05cc440..a3a1d7d56c67acc0eb6df9c424d12d07f289da81 100644 (file)
@@ -143,6 +143,7 @@ var goodLinkerFlags = [][]string{
        {"-L", "framework"},
        {"-framework", "Chocolate"},
        {"-v"},
+       {"-Wl,-sectcreate,__TEXT,__info_plist,${SRCDIR}/Info.plist"},
        {"-Wl,-framework", "-Wl,Chocolate"},
        {"-Wl,-framework,Chocolate"},
        {"-Wl,-unresolved-symbols=ignore-all"},