]> Cypherpunks repositories - gostls13.git/commitdiff
runtime: disable GDB tests on freebsd on all GOARCH values
authorYuval Pavel Zholkover <paulzhol@gmail.com>
Mon, 7 Jan 2019 22:54:58 +0000 (00:54 +0200)
committerBrad Fitzpatrick <bradfitz@golang.org>
Tue, 8 Jan 2019 00:35:16 +0000 (00:35 +0000)
The in-tree GDB is too old (6.1.1) on all the builders except the
FreeBSD 12.0 one, where it was removed from the base system.

Update #29508

Change-Id: Ib6091cd86440ea005f3f903549a0223a96621a6f
Reviewed-on: https://go-review.googlesource.com/c/156717
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>

src/runtime/runtime-gdb_test.go

index 442ee9ca813a10c86f5de00368228299caa5cafb..a988d1d702d950b3d92227199b167ffb028156b2 100644 (file)
@@ -39,9 +39,7 @@ func checkGdbEnvironment(t *testing.T) {
        case "aix":
                t.Skip("gdb does not work on AIX; see https://golang.org/issue/28558")
        case "freebsd":
-               if runtime.GOARCH == "arm" {
-                       t.Skip("skipping gdb tests on freebsd/arm; see https://golang.org/issue/29508")
-               }
+               t.Skip("skipping gdb tests on FreeBSD; see https://golang.org/issue/29508")
        }
        if final := os.Getenv("GOROOT_FINAL"); final != "" && runtime.GOROOT() != final {
                t.Skip("gdb test can fail with GOROOT_FINAL pending")