]> Cypherpunks repositories - gostls13.git/commitdiff
os/exec: disable tests on darwin/arm
authorDavid Crawshaw <crawshaw@golang.org>
Thu, 26 Feb 2015 14:44:41 +0000 (09:44 -0500)
committerDavid Crawshaw <crawshaw@golang.org>
Thu, 26 Feb 2015 16:19:46 +0000 (16:19 +0000)
There is only one process under the iOS sandboxd.

Change-Id: I21b5528366a0248a034801a717f24c60f0733c5f
Reviewed-on: https://go-review.googlesource.com/6101
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
src/os/exec/exec_test.go

index 197d3e8b40670f234825d50680f00478d7605f96..ebaef992bce4c13ddd41c79ba18d0433f051945f 100644 (file)
@@ -28,8 +28,9 @@ import (
 )
 
 func helperCommand(t *testing.T, s ...string) *exec.Cmd {
-       if runtime.GOOS == "nacl" {
-               t.Skip("skipping on nacl")
+       if runtime.GOOS == "nacl" || (runtime.GOOS == "darwin" && runtime.GOARCH == "arm") {
+               // iOS cannot fork
+               t.Skipf("skipping on %s/%s", runtime.GOOS, runtime.GOARCH)
        }
        cs := []string{"-test.run=TestHelperProcess", "--"}
        cs = append(cs, s...)
@@ -49,6 +50,10 @@ func TestEcho(t *testing.T) {
 }
 
 func TestCommandRelativeName(t *testing.T) {
+       if runtime.GOOS == "darwin" && runtime.GOARCH == "arm" {
+               t.Skip("skipping on darwin/arm")
+       }
+
        // Run our own binary as a relative path
        // (e.g. "_test/exec.test") our parent directory.
        base := filepath.Base(os.Args[0]) // "exec.test"
@@ -378,6 +383,10 @@ func TestExtraFiles(t *testing.T) {
        switch runtime.GOOS {
        case "nacl", "windows":
                t.Skipf("skipping test on %q", runtime.GOOS)
+       case "darwin":
+               if runtime.GOARCH == "arm" {
+                       t.Skipf("skipping test on %s/%s", runtime.GOOS, runtime.GOARCH)
+               }
        }
 
        // Ensure that file descriptors have not already been leaked into