]> Cypherpunks repositories - gostls13.git/commitdiff
io: use runtime.AddCleanup instead of runtime.SetFinalizer
authorCarlos Amedee <carlos@golang.org>
Mon, 23 Dec 2024 16:34:03 +0000 (11:34 -0500)
committerGopher Robot <gobot@golang.org>
Thu, 13 Feb 2025 17:11:02 +0000 (09:11 -0800)
Replace the usage of runtime.SetFinalizer with runtime.AddCleanup.

Updates #70907

Change-Id: Id604ca44ea67dcf8f87797e27347c6f4e9ad0b86
Reviewed-on: https://go-review.googlesource.com/c/go/+/638556
Reviewed-by: Michael Pratt <mpratt@google.com>
Auto-Submit: Carlos Amedee <carlos@golang.org>
TryBot-Bypass: Carlos Amedee <carlos@golang.org>

src/io/multi_test.go

index 7a24a8afc5a419ba433791536602366b00e0158d..934a6ec785fda4eddcc6d0308f523317207819f1 100644 (file)
@@ -332,9 +332,7 @@ func TestMultiReaderFreesExhaustedReaders(t *testing.T) {
                buf1 := bytes.NewReader([]byte("foo"))
                buf2 := bytes.NewReader([]byte("bar"))
                mr = MultiReader(buf1, buf2)
-               runtime.SetFinalizer(buf1, func(*bytes.Reader) {
-                       close(closed)
-               })
+               runtime.AddCleanup(buf1, func(ch chan struct{}) { close(ch) }, closed)
        }()
 
        buf := make([]byte, 4)