]> Cypherpunks repositories - gostls13.git/commitdiff
cmd/dist: test cgo internal linking on darwin-arm64
authorCherry Mui <cherryyz@google.com>
Tue, 8 Feb 2022 19:46:58 +0000 (14:46 -0500)
committerCherry Mui <cherryyz@google.com>
Tue, 8 Feb 2022 23:46:01 +0000 (23:46 +0000)
CL 383554 disables testing cgo internal linking on all ARM64 but
Windows, because it doesn't work with newer GCC. But
- darwin-arm64 works, and it does not use GCC
- we don't support cgo internal linking on windows-arm64 anyway.

This CL fixes the condition.

Change-Id: I9eb7b81ef75e482f5e95d2edae4863ba21396432
Reviewed-on: https://go-review.googlesource.com/c/go/+/384269
Trust: Cherry Mui <cherryyz@google.com>
Run-TryBot: Cherry Mui <cherryyz@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
src/cmd/dist/test.go

index 4b67565430cc0608f529c4dad690436f1e384154..d9eb9c3862ef917bfc962dcfd61de8c39779e0c3 100644 (file)
@@ -1119,7 +1119,7 @@ func (t *tester) cgoTest(dt *distTest) error {
 
        // Skip internal linking cases on arm64 to support GCC-9.4 and above.
        // See issue #39466.
-       skipInternalLink := goarch == "arm64" && goos != "windows"
+       skipInternalLink := goarch == "arm64" && goos != "darwin"
 
        if t.internalLink() && !skipInternalLink {
                cmd := t.addCmd(dt, "misc/cgo/test", t.goTest(), "-tags=internal")