]> Cypherpunks repositories - gostls13.git/commitdiff
[release-branch.go1.12] cmd/go/internal/modfetch: remove non-hermetic test
authorBryan C. Mills <bcmills@google.com>
Tue, 5 Nov 2019 16:01:10 +0000 (11:01 -0500)
committerBryan C. Mills <bcmills@google.com>
Wed, 11 Dec 2019 18:53:16 +0000 (18:53 +0000)
The test for gopkg.in/yaml.v2@v2 assumes that there are
no future upstream releases. That assumption empirically
does not hold. Backporting fixes to this test is annoying,
and other gopkg.in cases are already reasonably covered,
so remove the problematic test.

Updates #28856

Change-Id: I6455baa1816ac69e02d1ad5d03b82a93e1481a17
Reviewed-on: https://go-review.googlesource.com/c/go/+/205437
Run-TryBot: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
(cherry picked from commit f0390ffc9d461cb84207b5a94c4b645c87673406)
Reviewed-on: https://go-review.googlesource.com/c/go/+/205439
Reviewed-by: Alexander Rakoczy <alex@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>

src/cmd/go/internal/modfetch/coderepo_test.go

index f9d19f751e80f41688483b9b03ae662fc999bf6f..f2e44a00cda39b3a15bad04b8bfc97988897ad9d 100644 (file)
@@ -283,15 +283,6 @@ var codeRepoTests = []struct {
                time:    time.Date(2016, 12, 8, 18, 13, 25, 0, time.UTC),
                gomod:   "module gopkg.in/check.v1\n",
        },
-       {
-               path:    "gopkg.in/yaml.v2",
-               rev:     "v2",
-               version: "v2.2.5-0.20191002202810-970885f01c8b",
-               name:    "970885f01c8bc1fecb7ab1c8ce8e7609bda45530",
-               short:   "970885f01c8b",
-               time:    time.Date(2019, 10, 2, 20, 28, 10, 0, time.UTC),
-               gomod:   "module \"gopkg.in/yaml.v2\"\n\nrequire (\n\t\"gopkg.in/check.v1\" v0.0.0-20161208181325-20d25e280405\n)\n",
-       },
        {
                path:    "vcs-test.golang.org/go/mod/gitrepo1",
                rev:     "master",