]> Cypherpunks repositories - gostls13.git/commitdiff
Revert "runtime/pprof: unskip TestTimeVDSO on Android"
authorCherry Mui <cherryyz@google.com>
Tue, 6 Dec 2022 21:47:29 +0000 (21:47 +0000)
committerCherry Mui <cherryyz@google.com>
Tue, 6 Dec 2022 22:07:25 +0000 (22:07 +0000)
This reverts CL 455358, commit 98da0fb43fb481a25b3b4399cd9f517fe94d9f3f.

Reason for revert: still failing https://build.golang.org/log/c9f13a76069f523b5b4a37a75ec52b30a1f3427a

Change-Id: I8246d233c4fb86781b882f19dea82065cc21bc26
Reviewed-on: https://go-review.googlesource.com/c/go/+/455696
Run-TryBot: Cherry Mui <cherryyz@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Michael Pratt <mpratt@google.com>
src/runtime/pprof/pprof_test.go

index e83eb0015f84d6f5fa5983108af1c9a03578be56..39bc9d11f1e4e90cfd8dff0e5626df78fe6bfacf 100644 (file)
@@ -2262,6 +2262,11 @@ func TestTimeVDSO(t *testing.T) {
        // Test that time functions have the right stack trace. In particular,
        // it shouldn't be recursive.
 
+       if runtime.GOOS == "android" {
+               // Flaky on Android, issue 48655. VDSO may not be enabled.
+               testenv.SkipFlaky(t, 48655)
+       }
+
        matches := matchAndAvoidStacks(stackContains, []string{"time.now"}, avoidFunctions())
        p := testCPUProfile(t, matches, func(dur time.Duration) {
                t0 := time.Now()