]> Cypherpunks repositories - gostls13.git/commitdiff
net/http: correctly test for leading header spaces in TestReadRequest_Bad
authorDamien Neil <dneil@google.com>
Fri, 2 Sep 2022 21:48:28 +0000 (14:48 -0700)
committerDamien Neil <dneil@google.com>
Mon, 19 Sep 2022 17:14:09 +0000 (17:14 +0000)
TestReadRequest_Bad's tests for leading whitespace in the first header
were also exercising the test verifying that a HEAD request has no
Content-Length. Also, the test intended to test a leading tab was
actually testing for a leading \t (literal backslash, literal t).

Change-Id: I05b46d05851b49bf75f1d1257c421b953b66ea9c
Reviewed-on: https://go-review.googlesource.com/c/go/+/428134
Reviewed-by: Cherry Mui <cherryyz@google.com>
Run-TryBot: Damien Neil <dneil@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
src/net/http/readrequest_test.go

index a6a12a0ddde674cd223682a9b5bc29f366797f5c..ba5cf4a261d558136965677b19fc427cb7df93c9 100644 (file)
@@ -455,12 +455,10 @@ Host: foo
 Content-Length: 5`)},
 
        // golang.org/issue/22464
-       {"leading_space_in_header", reqBytes(`HEAD / HTTP/1.1
- Host: foo
-Content-Length: 5`)},
-       {"leading_tab_in_header", reqBytes(`HEAD / HTTP/1.1
-\tHost: foo
-Content-Length: 5`)},
+       {"leading_space_in_header", reqBytes(`GET / HTTP/1.1
+ Host: foo`)},
+       {"leading_tab_in_header", reqBytes(`GET / HTTP/1.1
+` + "\t" + `Host: foo`)},
 }
 
 func TestReadRequest_Bad(t *testing.T) {