]> Cypherpunks repositories - gostls13.git/commitdiff
internal/trace/v2: fix reader version for dumping text output
authorMichael Anthony Knyszek <mknyszek@google.com>
Mon, 25 Mar 2024 17:00:55 +0000 (17:00 +0000)
committerMichael Knyszek <mknyszek@google.com>
Mon, 25 Mar 2024 21:01:51 +0000 (21:01 +0000)
There was recently a failure that we don't have a trace dump for because
the reader was passed Go122 but traces have moved onto version Go123.
Use version.Current to prevent this from happening again in the future.

Change-Id: I4f8b3c3ea5bad61a07839a697cd5d7793d62ea52
Reviewed-on: https://go-review.googlesource.com/c/go/+/574216
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Carlos Amedee <carlos@golang.org>
src/internal/trace/v2/reader_test.go

index 393e1c80b060c0847d53908cff33e5e9ebfdeef5..121f0174edbd1020dd592012e3676c862d976b41 100644 (file)
@@ -133,7 +133,7 @@ func dumpTraceToText(t *testing.T, b []byte) string {
                t.Fatalf("dumping trace: %v", err)
        }
        var sb strings.Builder
-       tw, err := raw.NewTextWriter(&sb, version.Go122)
+       tw, err := raw.NewTextWriter(&sb, version.Current)
        if err != nil {
                t.Fatalf("dumping trace: %v", err)
        }