time: restore old error text for day out of range

Go 1.5 and earlier said "day out of range".
As part of working on this code it morphed into "day of month out of range".
To avoid churn in the output restore the old text.

This fixes some tests reported privately.

Change-Id: If179676cd49f9a471a9441fec2f5220c85eb0799
Reviewed-on: https://go-review.googlesource.com/18386
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>

diff --git a/src/time/format.go b/src/time/format.go
index fc2136a3f62aa76c05d92ff6b1ddf32b8719ad55..e616feb048fba087248ae3180c8d7c8b99382314 100644 (file)
--- a/src/time/format.go
+++ b/src/time/format.go
@@ -1002,7 +1002,7 @@ func parse(layout, value string, defaultLocation, local *Location) (Time, error)
 
        // Validate the day of the month.
        if day > daysIn(Month(month), year) {
-               return Time{}, &ParseError{alayout, avalue, "", value, ": day of month out of range"}
+               return Time{}, &ParseError{alayout, avalue, "", value, ": day out of range"}
        }
 
        if z != nil {

diff --git a/src/time/format_test.go b/src/time/format_test.go
index b6ea9afe7589fa68e613d4acbcaacf5a3c591a5b..af950a7c25b8e1b8f00c8d88335af3112da8526d 100644 (file)
--- a/src/time/format_test.go
+++ b/src/time/format_test.go
@@ -233,13 +233,13 @@ func TestParseDayOutOfRange(t *testing.T) {
                case test.ok && err == nil:
                        // OK
                case !test.ok && err != nil:
-                       if !strings.Contains(err.Error(), "day of month out of range") {
-                               t.Errorf("%q: expected 'day of month' error, got %v", test.date, err)
+                       if !strings.Contains(err.Error(), "day out of range") {
+                               t.Errorf("%q: expected 'day' error, got %v", test.date, err)
                        }
                case test.ok && err != nil:
                        t.Errorf("%q: unexpected error: %v", test.date, err)
                case !test.ok && err == nil:
-                       t.Errorf("%q: expected 'day of month' error, got none", test.date)
+                       t.Errorf("%q: expected 'day' error, got none", test.date)
                }
        }
 }