]> Cypherpunks repositories - gostls13.git/commitdiff
database/sql: remove an unused field from Rows
authorBrad Fitzpatrick <bradfitz@golang.org>
Mon, 6 May 2013 22:16:47 +0000 (15:16 -0700)
committerBrad Fitzpatrick <bradfitz@golang.org>
Mon, 6 May 2013 22:16:47 +0000 (15:16 -0700)
Found while debugging memory usage. Nobody accesses this field
anymore.

R=golang-dev, i.caught.air, adg, r
CC=golang-dev
https://golang.org/cl/9108043

src/pkg/database/sql/sql.go

index 0646fb796f7a8335e313689774fd82877f33ff9a..a80782bfedc87049f9b03efad253a9602576b031 100644 (file)
@@ -735,7 +735,6 @@ func (db *DB) queryConn(dc *driverConn, releaseConn func(error), query string, a
                        // Note: ownership of dc passes to the *Rows, to be freed
                        // with releaseConn.
                        rows := &Rows{
-                               db:          db,
                                dc:          dc,
                                releaseConn: releaseConn,
                                rowsi:       rowsi,
@@ -765,7 +764,6 @@ func (db *DB) queryConn(dc *driverConn, releaseConn func(error), query string, a
        // Note: ownership of ci passes to the *Rows, to be freed
        // with releaseConn.
        rows := &Rows{
-               db:          db,
                dc:          dc,
                releaseConn: releaseConn,
                rowsi:       rowsi,
@@ -1181,7 +1179,6 @@ func (s *Stmt) Query(args ...interface{}) (*Rows, error) {
        // Note: ownership of ci passes to the *Rows, to be freed
        // with releaseConn.
        rows := &Rows{
-               db:    s.db,
                dc:    dc,
                rowsi: rowsi,
                // releaseConn set below
@@ -1286,7 +1283,6 @@ func (s *Stmt) finalClose() error {
 //     err = rows.Err() // get any error encountered during iteration
 //     ...
 type Rows struct {
-       db          *DB
        dc          *driverConn // owned; must call releaseConn when closed to release
        releaseConn func(error)
        rowsi       driver.Rows