runtime, net: fixes from CL 68490043 review

These are mistakes in the first big NaCl CL.

LGTM=minux.ma, iant
R=golang-codereviews, minux.ma, iant
CC=golang-codereviews
https://golang.org/cl/69200043

diff --git a/src/pkg/runtime/arch_amd64.h b/src/pkg/runtime/arch_amd64.h
index 88b68cc6df58b7ebc500b5f0fbddbe537b8139ab..060c4d4f534f1315df8f6a330bc99d8bc1a41947 100644 (file)
--- a/src/pkg/runtime/arch_amd64.h
+++ b/src/pkg/runtime/arch_amd64.h
@@ -11,10 +11,6 @@ enum {
 #else
        RuntimeGogoBytes = 64,
 #endif
-#ifdef GOOS_nacl
-       PhysPageSize = 65536,
-#else
        PhysPageSize = 4096,
-#endif
        PCQuantum = 1
 };

diff --git a/src/pkg/runtime/arch_amd64p32.h b/src/pkg/runtime/arch_amd64p32.h
index 88b68cc6df58b7ebc500b5f0fbddbe537b8139ab..073a9e30e1de885a336fe8a26cad75ccba29b7cc 100644 (file)
--- a/src/pkg/runtime/arch_amd64p32.h
+++ b/src/pkg/runtime/arch_amd64p32.h
@@ -6,11 +6,7 @@ enum {
        thechar = '6',
        BigEndian = 0,
        CacheLineSize = 64,
-#ifdef GOOS_solaris
-       RuntimeGogoBytes = 80,
-#else
        RuntimeGogoBytes = 64,
-#endif
 #ifdef GOOS_nacl
        PhysPageSize = 65536,
 #else

diff --git a/src/pkg/runtime/runtime.h b/src/pkg/runtime/runtime.h
index 0069d5a774d71f8ae008f8c57d11849224d62bcf..e040c18272cc8bdaca5e3285258bc04790f82fbb 100644 (file)
--- a/src/pkg/runtime/runtime.h
+++ b/src/pkg/runtime/runtime.h
@@ -795,6 +795,8 @@ int32       runtime·charntorune(int32*, uint8*, int32);
  * first output value. Almost all code should write such
  * functions in .goc files, where goc2c (part of cmd/dist)
  * can arrange the correct alignment for the target system.
+ * Goc2c also takes care of conveying to the garbage collector
+ * which parts of the argument list are inputs vs outputs.
  *
  * Therefore, do NOT use this macro if at all possible.
  */