cmd/go: accept -Wl,-R/path/

Fixes #32167

Change-Id: If1277789ac96363430045e73e49d008bdae9be79
GitHub-Last-Rev: 71c9435c8417b19faaf66dc2e08740d7a9c22e3b
GitHub-Pull-Request: golang/go#32171
Reviewed-on: https://go-review.googlesource.com/c/go/+/178397
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>

diff --git a/src/cmd/go/internal/work/security.go b/src/cmd/go/internal/work/security.go
index ecfb9df1b219742b35bdb70752f0a68c78ac6e0c..0d8da21ae388793379568c4b510fee06baeb372f 100644 (file)
--- a/src/cmd/go/internal/work/security.go
+++ b/src/cmd/go/internal/work/security.go
@@ -184,6 +184,8 @@ var validLinkerFlags = []*lazyregexp.Regexp{
        re(`-Wl,-framework,[^,@\-][^,]+`),
        re(`-Wl,-headerpad_max_install_names`),
        re(`-Wl,--no-undefined`),
+       re(`-Wl,-R([^@\-][^,@]*$)`),
+       re(`-Wl,--just-symbols[=,]([^,@\-][^,@]+)`),
        re(`-Wl,-rpath(-link)?[=,]([^,@\-][^,]+)`),
        re(`-Wl,-s`),
        re(`-Wl,-search_paths_first`),
@@ -213,6 +215,8 @@ var validLinkerFlagsWithNextArg = []string{
        "-target",
        "-Wl,-framework",
        "-Wl,-rpath",
+       "-Wl,-R",
+       "-Wl,--just-symbols",
        "-Wl,-undefined",
 }
 

diff --git a/src/cmd/go/internal/work/security_test.go b/src/cmd/go/internal/work/security_test.go
index d23b6eadff50e8db21e368755f9ee3530691bc61..fd8caeab4ecf7dd0286ba26df65fb15dc05cc440 100644 (file)
--- a/src/cmd/go/internal/work/security_test.go
+++ b/src/cmd/go/internal/work/security_test.go
@@ -125,6 +125,11 @@ var goodLinkerFlags = [][]string{
        {"-pthread"},
        {"-Wl,-rpath,foo"},
        {"-Wl,-rpath,$ORIGIN/foo"},
+       {"-Wl,-R", "/foo"},
+       {"-Wl,-R", "foo"},
+       {"-Wl,-R,foo"},
+       {"-Wl,--just-symbols=foo"},
+       {"-Wl,--just-symbols,foo"},
        {"-Wl,--warn-error"},
        {"-Wl,--no-warn-error"},
        {"foo.so"},
@@ -197,6 +202,9 @@ var badLinkerFlags = [][]string{
        {"-x", "--c"},
        {"-x", "@obj"},
        {"-Wl,-rpath,@foo"},
+       {"-Wl,-R,foo,bar"},
+       {"-Wl,-R,@foo"},
+       {"-Wl,--just-symbols,@foo"},
        {"../x.o"},
 }