]> Cypherpunks repositories - gostls13.git/commitdiff
strings: avoid unnecessary variable setting
authorKevin Burke <kev@inburke.com>
Thu, 3 Aug 2017 05:24:22 +0000 (22:24 -0700)
committerBrad Fitzpatrick <bradfitz@golang.org>
Wed, 9 Aug 2017 04:19:17 +0000 (04:19 +0000)
We initialize fieldStart to 0, then set it to i without ever reading
0, so we might as well just initialize it to i.

Change-Id: I17905b25d54a62b6bc76f915353756ed5eb6972b
Reviewed-on: https://go-review.googlesource.com/52933
Reviewed-by: Martin Möhrmann <moehrmann@google.com>
Reviewed-by: Avelino <t@avelino.xxx>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
src/strings/strings.go

index 0c836c09d46ae839599cf78f077e8159b360f10a..52466e924debbda89110e2cd2e2d8e0d4e2ce930 100644 (file)
@@ -363,7 +363,6 @@ func Fields(s string) []string {
        // a non-ASCII rune needs to be decoded and checked
        // if it corresponds to a space.
        a := make([]string, 0, n)
-       fieldStart := 0
        i := 0
        // Skip spaces in the front of the input.
        for i < len(s) {
@@ -380,7 +379,7 @@ func Fields(s string) []string {
                        i += w
                }
        }
-       fieldStart = i
+       fieldStart := i
        for i < len(s) {
                if c := s[i]; c < utf8.RuneSelf {
                        if asciiSpace[c] == 0 {