]> Cypherpunks repositories - gostls13.git/commitdiff
syscall: disable c-shared test when no cgo, for windows/arm
authorJason A. Donenfeld <Jason@zx2c4.com>
Tue, 15 Jun 2021 15:04:01 +0000 (17:04 +0200)
committerJason A. Donenfeld <Jason@zx2c4.com>
Tue, 15 Jun 2021 16:53:28 +0000 (16:53 +0000)
The windows/arm port does not yet support cgo, so disable a test that
requires it. This fixes a regression from CL 327969, which added support
for arm64, but errantly dropped the t.Skip for both arm and arm64,
rather than just for arm64. With this commit, we make the test specific
to cgo, rather than the architecture.

Change-Id: Ibe1166c1965e007c7af899b07ded65f2a2633ddd
Reviewed-on: https://go-review.googlesource.com/c/go/+/327970
Trust: Jason A. Donenfeld <Jason@zx2c4.com>
Run-TryBot: Jason A. Donenfeld <Jason@zx2c4.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
src/syscall/syscall_windows_test.go

index 581a246cd93a83d189b6826697ebbbafc9fdf70b..194c87805cdd750c1d60b21b4ee623e6aa1bb270 100644 (file)
@@ -78,6 +78,7 @@ func TestTOKEN_ALL_ACCESS(t *testing.T) {
 
 func TestStdioAreInheritable(t *testing.T) {
        testenv.MustHaveGoBuild(t)
+       testenv.MustHaveCGO(t)
        testenv.MustHaveExecPath(t, "gcc")
 
        tmpdir := t.TempDir()