]> Cypherpunks repositories - gostls13.git/commitdiff
go/types: fix type in Interface.Complete method
authorRobert Griesemer <gri@golang.org>
Wed, 22 Nov 2017 21:12:42 +0000 (13:12 -0800)
committerRobert Griesemer <gri@golang.org>
Wed, 22 Nov 2017 22:37:15 +0000 (22:37 +0000)
This doesn't appear to have caused problems (because we don't depend
on the sort order, it seems) but it's clearly incorrect.

Change-Id: Ib6eb0128a3c17997c7907a618f9ce102b32aaa98
Reviewed-on: https://go-review.googlesource.com/79497
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>

src/go/types/type.go

index f4cf61d8e67142a1457bea81277c6188569c10bb..4c681a79c4d6986d554b741f8e5c8034dc7b6ca4 100644 (file)
@@ -262,7 +262,7 @@ func NewInterface(methods []*Func, embeddeds []*Named) *Interface {
        }
        sort.Sort(byUniqueMethodName(methods))
 
-       if embeddeds == nil {
+       if embeddeds != nil {
                sort.Sort(byUniqueTypeName(embeddeds))
        }