]> Cypherpunks repositories - gostls13.git/commitdiff
cmd/internal/obj/arm64: simplify some bool expressions
authorIskander Sharipov <iskander.sharipov@intel.com>
Wed, 11 Jul 2018 20:39:49 +0000 (23:39 +0300)
committerBrad Fitzpatrick <bradfitz@golang.org>
Wed, 22 Aug 2018 16:24:52 +0000 (16:24 +0000)
Replace `!(o1 != 0)` with `o1 == 0` (for readability).

Found using https://go-critic.github.io/overview.html#boolExprSimplify-ref

Change-Id: I4fc035458f530973f9be15b38441ec7b5fb591ec
Reviewed-on: https://go-review.googlesource.com/123377
Run-TryBot: Iskander Sharipov <iskander.sharipov@intel.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
src/cmd/internal/obj/arm64/asm7.go

index 4840a969fd6658e747e67c99ae36cb6d21b8c70b..1acf9799c626e0de026723b0f062d2d347f9aeca 100644 (file)
@@ -2752,7 +2752,7 @@ func (c *ctxt7) asmout(p *obj.Prog, o *Optab, out []uint32) {
        case 13: /* addop $vcon, [R], R (64 bit literal); cmp $lcon,R -> addop $lcon,R, ZR */
                o1 = c.omovlit(AMOVD, p, &p.From, REGTMP)
 
-               if !(o1 != 0) {
+               if o1 == 0 {
                        break
                }
                rt := int(p.To.Reg)
@@ -3013,7 +3013,7 @@ func (c *ctxt7) asmout(p *obj.Prog, o *Optab, out []uint32) {
        case 28: /* logop $vcon, [R], R (64 bit literal) */
                o1 = c.omovlit(AMOVD, p, &p.From, REGTMP)
 
-               if !(o1 != 0) {
+               if o1 == 0 {
                        break
                }
                rt := int(p.To.Reg)
@@ -3158,7 +3158,7 @@ func (c *ctxt7) asmout(p *obj.Prog, o *Optab, out []uint32) {
        case 34: /* mov $lacon,R */
                o1 = c.omovlit(AMOVD, p, &p.From, REGTMP)
 
-               if !(o1 != 0) {
+               if o1 == 0 {
                        break
                }
                o2 = c.opxrrr(p, AADD, false)