]> Cypherpunks repositories - gostls13.git/commitdiff
encoding/binary: clarify the repercussions for not following the docs
authorBrad Fitzpatrick <bradfitz@golang.org>
Wed, 28 Jun 2017 23:12:41 +0000 (23:12 +0000)
committerBrad Fitzpatrick <bradfitz@golang.org>
Thu, 29 Jun 2017 03:29:11 +0000 (03:29 +0000)
Fixes #19794

Change-Id: I462cbc432fe9d4a9e6e79a9833b0013d82a0780e
Reviewed-on: https://go-review.googlesource.com/47093
Reviewed-by: Ian Lance Taylor <iant@golang.org>
src/encoding/binary/binary.go

index 383425459666a220d827df5cab7832ad14f16da4..2d01a3cb287b5dc32201e64c50a8ae5db65ab6a5 100644 (file)
@@ -152,7 +152,8 @@ func (bigEndian) GoString() string { return "binary.BigEndian" }
 // When reading into structs, the field data for fields with
 // blank (_) field names is skipped; i.e., blank field names
 // may be used for padding.
-// When reading into a struct, all non-blank fields must be exported.
+// When reading into a struct, all non-blank fields must be exported
+// or Read may panic.
 //
 // The error is EOF only if no bytes were read.
 // If an EOF happens after reading some but not all the bytes,